github / github/codeql

False positive in CWE-829 /UntrustedCheckoutMedium.ql

Open
#21,823 1 comment 0 reactions 0 assignees View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**
When there is a workflow that is triggered by a pull_request, this check considers the called workflow to be privileged even though it is not.

**Code samples or links to source code**

Triggered Workflow: https://raw.githubusercontent.com/llvm/llvm-project/refs/heads/main/.github/workflows/release-binaries-all.yml
Called Workflow: https://raw.githubusercontent.com/llvm/llvm-project/refs/heads/main/.github/workflows/release-binaries.yml

**URL to the alert on GitHub code scanning (optional)**

https://github.com/llvm/llvm-project/security/code-scanning/1828

Contributor guide

Open the contributing guide

Research direction

Start with the CWE-829 /UntrustedCheckoutMedium.ql query and review the triggered and called workflow examples linked in the report. Compare the query result with the pull_request-triggered workflow behavior and the linked code-scanning alert. Done means the called workflow is no longer incorrectly reported as privileged.

Written by the indexing model from the issue text.

Assessment

Tech stack
github, github-actions
Domain
ci-cd, security
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.