github / github/codeql

Incomplete naming schema and API usage patterns in py/insecure-cookie

未關閉
#21,647 1 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

1. The existing `cookie.isSensitive` predicate seems to miss common modern authentication token patterns. I have found some and listed them below.
2. The rule currently relies primarily on specific framework methods (e.g., set_cookie). It ignores direct HTTP manipulation, which is also very common.

code example:
```python
from flask import Flask, Response, make_response

app = Flask(__name__)

@app.route("/login")
def login():
resp = make_response("Logged in")
resp.set_cookie("authKey", "secret123") # $ Alert[py/insecure-cookie]
resp.set_cookie("accessToken", "secret123") # $ missing
resp.set_cookie("access_token", "secret123") # missing
resp.set_cookie("auth_token", "secret123") # missing
resp.set_cookie("jwt", "secret123") # $ missing
resp.set_cookie("oauth_token", "secret123") # $ missing

# cannot support this
resp.headers.add("Set-Cookie", "authKey=secret123") # missing

# This is also common, but it seems more difficult to support this.
from http.cookies import SimpleCookie
resp = make_response("Logged in")
cookie = SimpleCookie()
cookie["session"]['authKey'] = "secret123" # missing
# cookie["session"]["httponly"] = True
# cookie["session"]["secure"] = True
for key, morsel in cookie.items():
resp.headers.add('Set-Cookie', morsel.OutputString())
return resp
```

貢獻指南

開啟貢獻指南

研究方向

Start at the py/insecure-cookie rule and inspect the cookie.isSensitive predicate and the set_cookie handling described in the issue. Compare the listed token names and direct Set-Cookie examples against current behavior; done means the supported authentication-cookie patterns are detected without relying only on framework methods.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
python
領域
security
Issue 類型
功能
難度
4/5
預估耗時
3-5 天
活躍度
冷清
描述清晰度
基本清楚
新手友好度
52/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。