github / github/codeql

JavaScript DOM XSS via fetch().json() → insertAdjacentHTML not detected by CodeQL

Aperta
#21,257 2 commenti 0 reazioni 0 assegnatari Vedi su GitHub
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

**Description of the false positive**

We are trying to better understand the design decisions behind JavaScript XSS detection in CodeQL, specifically around taint sources involving network responses.

I have a piece of client-side JavaScript that builds HTML using `insertAdjacentHTML` with values coming from a fetch().json() response. From an application-security perspective, this is treated as a potential DOM XSS risk in our project, but CodeQL does not report it.

I’d like to confirm whether this behavior is by design, and if so, what the recommended way is to model this trust boundary.

**Code samples or links to source code**

```
function loadMessageLogs(pageSize, continuationToken) {
let url = '?handler=LoadMessageLogs&pageSize=' + pageSize;
if (continuationToken)
url += '&continuationToken=' + encodeURIComponent(continuationToken);

fetch(url)
.then(response => response.json())
.then(data => {
const tbody = document.querySelector("#tblMessageLogs tbody");
tbody.innerHTML = "";

if (!data.items || data.items.length === 0) {
messageLogs.hidden = true;
noMessageLogs.hidden = false;
}
else {

data.items.forEach(item => {
const link = `View message`;
const row = `
${item.createdDate}
${item.messageId}
${item.interfaceId ?? ''}
${item.target ?? ''}
${item.mpanCore ?? ''}
${item.meterId ?? ''}
${link}
`;
tbody.insertAdjacentHTML('beforeend', row);
});

PagingModule.updatePaging(data.continuationToken)
messageLogs.hidden = false;
noMessageLogs.hidden = true;
}
});
}
```

In our case, `data.items[*]` ultimately contains data that may originate from user input stored and returned by the backend.

- We are running the javascript-security-extended query suite.
- No XSS issue is reported for this code.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start with the JavaScript security-extended query suite and review how fetch().json() responses and insertAdjacentHTML are modeled. Determine whether this flow is intentionally excluded or needs source and sink modeling, then validate the conclusion against the supplied example and confirm whether an XSS result is expected.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
security
Tipo di issue
Bug
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Da chiarire
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.