[Actions] CWE-285/ImproperAccessControl.ql Not Currently Working
- Dominant language
- CodeQL
- Stars
- 10.1k
- Forks
- 2.1k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 141
Description
**Description of the issue**
The Actions ImproperAccessControl query is not working even for trivial workflows. This is an example from https://github.com/github/codeql/blob/main/actions/ql/src/Security/CWE-285/ImproperAccessControl.md and does not trigger a detection.
```yaml
on:
pull_request_target:
types: [opened, synchronize]
jobs:
test:
runs-on: ubuntu-latest
steps:
- name: Checkout repo for OWNER TEST
uses: actions/checkout@v3
if: contains(github.event.pull_request.labels.*.name, 'safe to test')
with:
ref: ${{ github.event.pull_request.head.sha }}
- run: ./cmd
```
All my attempts to try variations that did trigger a finding also failed. Is this detection enabled as part of the default suite (it appears to be)?
Contributor guide
Research direction
Start by reproducing the workflow example from actions/ql/src/Security/CWE-285/ImproperAccessControl.md and inspect the corresponding ImproperAccessControl.ql query. Check whether the query is included in the default suite; done means explaining or correcting why the example produces no finding.
Written by the indexing model from the issue text.
Assessment
- Domain
- security
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100