github / github/codeql

[Python] General issue: Wrong domination is reported in control flow analysis

Open
#20,551 1 comment 0 reactions 1 assignee Claimed by @tausbn View on GitHub
question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the issue**
I have a python code and ql as follows:
``` python
def EXEC():
raise Exception("Test exception")

def API():
pass

def DUMMY():
pass

try:
EXEC()
API()
except Exception as e:
raise(e)
finally:
DUMMY()
```
``` ql
/**
* @kind problem
* @problem.severity warning
* @id python/find-if
*/

import python

predicate isCall(Call call, string name) {
exists (Name n | call.getFunc() = n and n.getId() = name)
}

from Call callAPI, Call callDummy
where
isCall(callAPI, "API") and isCall(callDummy, "DUMMY") and
not exists (ControlFlowNode nAPI, ControlFlowNode nDummy |
nAPI = callAPI.getAFlowNode() and nDummy = callDummy.getAFlowNode() and
nAPI.dominates(nDummy))
select callAPI, callAPI.toString()
```

The ql code simply check if the call to `API()` does not dominate the call to `DUMMY()`
**Expected Behaviour**: Call to `API()` is reported because `API()` does not dominate `DUMMY()`.
**Actual Result**: nothing is reported

CodeQL version: `CodeQL command-line toolchain release 2.23.1.`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.