UnvalidatedDynamicMethodCall query does not detect flow inside try/catch
- Lingua principale
- CodeQL
- Stelle
- 10.1k
- Fork
- 2.1k
- Merge medio
- 2g 15h
- PR unite (30g)
- 141
Descrizione
Hi CodeQL team 👋
I'm currently building some training challenges for developers to help them identify insecure dynamic method calls. I designed one of the [exercises](https://github.com/fguisso/backoffice-balm) based on the `UnvalidatedDynamicMethodCall` alert.
However, I noticed that the vulnerability I created was not detected by the query. After a lot of debugging, I suspect the query does not handle taint flow properly when the logic is inside arrow functions.
- The vulnerable code uses an Express route with an arrow function as the handler.
- Inside the arrow function, I access `req.params.action` and use it to dynamically invoke a method: `userManager[action](...)`.
- This allows access to both regular and admin-only methods of the userManager object.
Unfortunately, this pattern wasn't flagged by the query, even though it's clearly unsafe.
I'm still learning how CodeQL queries work, and I'm not very experienced with the query language yet. I'd really appreciate any help understanding why this scenario is missed, and how I might contribute a feature for it.
I'd love to open a PR — just need some guidance on how to proceed the right way.
`update`: I have tested here like @rvermeulen said and the catch is the `try/catch`.
`git blaming` cc: @asgerf
Guida per i contributori
Apri la guida per i contributori
Direzione di ricerca
Inizia con la query UnvalidatedDynamicMethodCall e riproduci la challenge di training collegata nell’issue. Confronta la route Express che usa req.params.action all’interno di un gestore arrow-function con e senza try/catch, quindi conferma che la chiamata dinamica vulnerabile viene rilevata quando l’issue è risolta.
Scritto dal modello di indicizzazione a partire dal testo della issue.
Valutazione
- Stack tecnologico
- express, javascript
- Ambito
- security
- Tipo di issue
- Bug
- Difficoltà
- 4/5
- Tempo stimato
- 3-5 giorni
- Stato di attività
- Ferma
- Chiarezza
- Abbastanza chiara
- Idoneità per principianti
- 35/100