github / github/codeql

CodeQL analysis does not detect expected command injection vulnerability

未关闭
#19,811 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
question
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

**Hello CodeQL team**,

I'm currently integrating CodeQL into our CI workflow for an end-to-end security test of our backend system.

Here's the procedure I followed:

Setup:
**Downloaded the CLI:**
wget https://github.com/github/codeql-cli-binaries/releases/latest/download/codeql-linux64.zip
unzip codeql-linux64.zip
sudo mv codeql /usr/local/bin/

**Cloned the CodeQL repository with Python libraries:**
git clone https://github.com/github/codeql.git

**Inside the backend directory, created the database:**
codeql database create db-python --language=python --source-root=.

**Ran the analysis:**
codeql database analyze db-python codeql/python/ql/src/codeql-suites/python-lgtm-full.qls --format=sarifv2.1.0 --output=python-code-scanning-sec-all.sarif

**Checked the results:**
jq '.runs[].results[] | {message: .message.text, severity: .level, location: .locations[0].physicalLocation.artifactLocation.uri}' python-code-scanning-sec-all.sarif

**Problem**
Before running the scan, I added the following code snippet to the backend intentionally to trigger a command injection warning:

```
import os
user_input = input("Enter command: ")
os.system(user_input) # ⚠️ This should trigger a CodeQL rule: command injection
```
However, the scan results do not include any findings related to this vulnerable code.

**Question**
Am I missing something in the setup or the suite configuration?
Is there a different CodeQL query or suite that should be used to detect this specific type of vulnerability (e.g., command injection via os.system) in Python?

Any help or guidance would be much appreciated!

Best regards,
Anton

贡献指南

打开贡献指南

调研方向

Reproduce the report with the shown Python snippet, the db-python database, and codeql/python/ql/src/codeql-suites/python-lgtm-full.qls. Inspect the generated python-code-scanning-sec-all.sarif results and the suite configuration to determine why no finding appears. Done means identifying the cause and documenting the required query or setup for detecting this case.

由索引模型根据 Issue 内容生成。

评估

技术栈
python
领域
security
Issue 类型
缺陷
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
需要澄清
新手友好度
30/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。