github / github/codeql

The strings were concatenated, making it impossible to match the path.

Aperta
#19,479 4 commenti 0 reazioni 0 assegnatari Vedi su GitHub
question
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

Source can query the fileName.
![Image](https://github.com/user-attachments/assets/be6b5bb4-8bf2-473e-8ec7-8473f65aed09)
Sink can also query data.
![Image](https://github.com/user-attachments/assets/0bb4c178-36e3-49a9-9866-31b3b578fb8d)
Logic can be connected.
![Image](https://github.com/user-attachments/assets/b0066f0d-42c9-4597-b37b-bfc10f14d6ef)
But no results were found.
![Image](https://github.com/user-attachments/assets/83905e7f-0c2b-49ad-a946-f7b9edd55b53)
The test from fileName to FileUtils.isValidFilename can retrieve results.
![Image](https://github.com/user-attachments/assets/62a80658-e043-449d-9497-19b0b0b5d12f)
However, when querying from fileName to writeBytes, no results are returned. The data passes through the line "String filePath = Global.getDownloadPath() + fileName;" in the middle.

![Image](https://github.com/user-attachments/assets/afec0902-6c54-4297-a185-9cda90eb2087)

![Image](https://github.com/user-attachments/assets/00b657c6-ee6c-427c-bdca-de738f941534)

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by tracing the reported flow from fileName through "String filePath = Global.getDownloadPath() + fileName;" to writeBytes, and compare it with the path to FileUtils.isValidFilename. Inspect how the CodeQL data-flow query handles the concatenation, then verify that the fileName-to-writeBytes query returns a result while the existing path remains covered.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
java
Ambito
security
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.