github / github/codeql

Experimental CodeInjection query for JavaScript doesn't seem to work

未關閉
#18,619 2 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
question
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

I noticed that the sources and sinks for some of the code injection CVEs in JavaScript were spread out among different queries making it difficult or impossible to find the issues in some cases. I also saw that there is an experimental suite of Javascript Security queries that add additional sources.

I tested the experimental query for code injection located [here](https://github.com/github/codeql/blob/edb9b47111518c0e3791a5db9d47f42e1476a487/javascript/ql/src/experimental/heuristics/ql/src/Security/CWE-094/CodeInjection.ql) on some simple js code that contains a use of `JSON.stringify` as source and `eval` as sink. I know this should be covered because there is a private class for `JSON.stringify` in the AdditionalSources.qll that CodeInjection.ql imports.

```
/**
* A use of `JSON.stringify`, viewed as a source for command-line injections
* since it does not properly escape single quotes and dollar symbols.
*/
private class JsonStringifyAsCommandInjectionSource extends HeuristicSource,
CommandInjection::Source instanceof JsonStringifyCall
{
override string getSourceType() { result = "a string from JSON.stringify" }
}

```

When I run it on this code, I get 0 results:

```
import fs from 'fs';

function encodeStatements(statements) {

eval(JSON.stringify(statements))

}

module.exports = encodeStatements;

```

I tested with this query to ensure that the sink was recognized which it was.

```

import javascript
import semmle.javascript.security.dataflow.CodeInjectionQuery
import CodeInjectionFlow::PathGraph
import semmle.javascript.heuristics.AdditionalSources

from DataFlow::Node sink
where CodeInjectionConfig::isSink(sink)
select sink, "Sink found"
```

When I tried the same thing for sources I got received 0 results in the source code. However I ran this query which confirmed that `JSON.stringify` is part of the sources added as HeuristicSource, so I'm very confused as to why this doesn't work.

```
import javascript
import semmle.javascript.security.dataflow.CodeInjectionQuery
import CodeInjectionFlow::PathGraph
import semmle.javascript.heuristics.AdditionalSources

from DataFlow::Node source
where source instanceof HeuristicSource
select source, "User input"

```

Not sure where the error here lies but I could use some help diagnosing it. Thanks!

貢獻指南

開啟貢獻指南

研究方向

Start with the experimental Security/CWE-094/CodeInjection.ql query and the AdditionalSources.qll definitions, then run the supplied JavaScript example and the two diagnostic queries. Done means determining why JSON.stringify is not recognized as a source in the CodeInjection query and documenting or correcting that behavior so the example produces the expected result.

由索引模型根據 Issue 內容生成。

評估

技術堆疊
javascript
領域
security
Issue 類型
缺陷
難度
4/5
預估耗時
3-5 天
活躍度
停滯
描述清晰度
基本清楚
新手友好度
35/100

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。