github / github/codeql

Go: `LoadGoModules` incorrectly still flags 1.23 as an invalid toolchain

Offen
#18,447 2 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
false-positive
Vorherrschende Sprache
CodeQL
Sterne
10.1k
Forks
2.1k
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
141

Beschreibung

**Description of the false positive**

The Go team had a change of heart in Go 1.23 and re-permitted `go 1.23` as an alias for `go 1.23.0`

The change in behaviour in 1.23 is referenced in this comment on this well-cited GH issue on the confusion around the go directive changes:

![image](https://github.com/user-attachments/assets/cd30e750-f034-4d88-896d-5d408d900b86)

https://github.com/golang/go/issues/62278#issuecomment-2062002018

However, CodeQL is flagging this as invalid due to not using 1.N.P syntax:

> Invalid Go toolchain version
>
> As of Go 1.21, toolchain versions [must use the 1.N.P syntax](https://go.dev/doc/toolchain#version).
>
> 1.23 in go.mod does not match this syntax and there is no additional toolchain directive, which may cause some go commands to fail.

**Code samples or links to source code**

Reduced testcase pushed as a sample repo here with CodeQL scanning enabled:

https://github.com/dnwe/go-codeql

**URL to the alert on GitHub code scanning**

https://github.com/dnwe/go-codeql/security/code-scanning/tools/CodeQL/status/configurations/actions-FZTWS5DIOVRC653POJVWM3DPO5ZS6Y3PMRSXC3BNMFXGC3DZONUXGLTZNVWA/c1646cb64b746876ea230e833d950329e5308885d88be821300b330d9b9a7f83

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the reduced testcase in the linked go-codeql sample repository and the CodeQL alert, then trace the LoadGoModules entry point that reports the invalid toolchain version. Confirm that go 1.23 is accepted as an alias for go 1.23.0, and verify that the alert is no longer produced for this case.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
go
Bereich
devtools
Issue-Typ
Bug
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
42/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.