False positive for Prototype-polluting function
- 主要语言
- CodeQL
- 星标
- 10.1k
- 派生
- 2.1k
- 平均合并
- 2 天 15 小时
- 30 天内合并 PR
- 141
描述
I check for prototype polluting property keys in a set of reserved keys which include `__proto__` and `constructor`.
This shouldn't even be necessary since the key, value come from Object.entries which according to MDN will only iterate own enumerable string-keyd property. ie. never `__proto__` or `constructor`.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/entries

Still the lookup in the set does not work.
```js
// Iterate through the source own enumerable string-keyed property key-value pairs.
for (const [key, value] of Object.entries(source)) {
// This for codeql only. key, value of Object.entries should ensure that only own properties are parsed
if (!source.hasOwnProperty(key)) continue;
// The ignoreKeys contain checks against prototype pollution.
if (new Set(['__proto__', 'constructor', 'mapview']).has(key)) {
continue;
}
```
CodeQL looks at the right place but ignores the check for the set.
https://github.com/GEOLYTIX/xyz/security/code-scanning/217

The only way I can make the issue go away is by doing a === check on the string value like so.
```js
// Prevent prototype polluting assignment.
if (key === '__proto__' || key === 'constructor') return true;
```
Even though I know that this issue can not happen I need to add this extra line to make the CodeQL warning go away.
贡献指南
调研方向
从链接的 CodeQL 代码扫描警报和报告的 JavaScript 代码片段开始;未指定任何仓库文件或测试。跟踪相关查询如何处理 Object.entries 和 Set 成员关系,然后添加或更新回归覆盖,以便不再报告此误报。
由索引模型根据 Issue 内容生成。
评估
- 技术栈
- javascript
- 领域
- security
- Issue 类型
- 缺陷
- 难度
- 4/5
- 预计耗时
- 3-5 天
- 活跃度
- 停滞
- 描述清晰度
- 需要澄清
- 新手友好度
- 25/100