github / github/codeql

C#: Azure Function HttpTrigger SQL Injection is not being detected

未關閉
#15,102 5 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
question
主要語言
CodeQL
星號
10.1k
分支
2.1k
平均合併
2 天 15 小時
30 天內合併 PR
141

描述

**Description of the issue**

CodeQL scan is not picking up SQL Injection vulnerability in the following Azure Function trigger:

```csharp
using System.Net;
using Microsoft.Azure.Functions.Worker;
using Microsoft.Azure.Functions.Worker.Http;
using Microsoft.Data.Sqlite;
using Microsoft.Extensions.Logging;
using Dapper;

namespace DavidF.Demo.GithubActions.Functions;

public class HelloWorldFunction
{
private readonly SqliteConnection _sqliteConnection;
private readonly ILogger _logger;

public HelloWorldFunction(ILoggerFactory loggerFactory, SqliteConnection sqliteConnection)
{
_sqliteConnection = sqliteConnection;
_logger = loggerFactory.CreateLogger();
}

[Function("HelloWorldFunction")]
public async Task Run([HttpTrigger(AuthorizationLevel.Function, "get", "post")] HttpRequestData req)
{
_logger.LogInformation("C# HTTP trigger function processed a request.");

var sql = $"SELECT * FROM USER WHERE Name = '{req.Query["name"]}'";

_sqliteConnection.Open();

var res = await _sqliteConnection.QueryAsync(sql);

var response = req.CreateResponse(HttpStatusCode.OK);

await response.WriteAsJsonAsync(res);

return response;
}

public record UserDto(long Id, string Name);
}
```

Tested in GitHub actions and also locally using CLI:

```powershell
c:\codeql\codeql.exe database analyze "codeql-db" --format=sarif-latest --output="codeql-output" --threads=0 '..\codeql\csharp\ql\src\Security Features\cwe-089\SqlInjection.ql'
```

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。