github / github/codeql

False positive: Cyclic import in Python

Aperta
#13,866 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
false-positive Python
Lingua principale
CodeQL
Stelle
10.1k
Fork
2.1k
Merge medio
2g 15h
PR unite (30g)
141

Descrizione

**Description of the false positive**

CodeQL falsely detects a cyclic import in a Pull request.

* There is an existing cyclic import in the code which is mitigated with an import inside of a function.
> toolopts imports global variables from systeminfo inside of `_register_options()`
> systeminfo imports toolopts
* The pull request includes switching the python modules that the identifiers are being defined in and reversing the imports so that only one module has to import the other
> toolopts now implements the global variables
> toolopts no longer imports systeminfo at all
> systeminfo now imports the global variables from toolopts

**Code samples or links to source code**

* Site of the additional import: https://github.com/oamg/convert2rhel/pull/820/files#diff-1e030442df599479d1af356a7eaa61a744973513548846a1a885b8eaca6f489cR28
* Site of the removal of import: https://github.com/oamg/convert2rhel/pull/820/files#diff-a7331917babf0a1504893963baab7ad842640877734e5dbeb39ebf97ec584565L130

**URL to the alert on GitHub code scanning (optional)**

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.