github / github/codeql

False negative: java string concatenation using StringBuilder causing injection

未关闭
#12,939 6 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
Java question
主要语言
CodeQL
星标
10.1k
派生
2.1k
平均合并
2 天 15 小时
30 天内合并 PR
141

描述

**Description of the issue**

CodeQL correctly detected a Java code issue that involved Java string concatenation being passed to `Runtime.getRuntime().exec("")`. In our case it wasn't exploitable, but it was still dangerous code that needed to be remediated.

**Code samples**
The code (not mine!) looked a bit like like this:
`Process p = Runtime.getRuntime().exec("python " + SCRIPT_PATH + " --file " + inputFile.getAbsolutePath());`

The developer attempted to correct the issue on their own and changed it to this:
```
StringBuilder pythonPath = new StringBuilder();
pythonPath.append("python ").append(SCRIPT_PATH).append(" --file ").append(inputFile.getAbsolutePath());
Process p = Runtime.getRuntime().exec(pythonPath.toString());
```

CodeQL closed the alert as fixed, even though the new code is still vulnerable and logically the same.

It appears as though CodeQL is not properly detecting Java string concatenation vulnerabilities whenever the `StringBuilder` class is used. `StringBuilder` is fairly common, so this results in some risky omissions.

**CodeQL Rule**
Rule ID: java-concatenated-command-line

**Build-Time Environment**
Language: java
Java Distribution: temurin
Java Version: 8 (via `setup-java@v3`)
Java Build Tool: Maven 3.8.2

贡献指南

打开贡献指南

评估

这个 Issue 还没有评估数据。

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。