github / github/codeql

Find a double free

Open
#12,455 5 comments 0 reactions 0 assignees View on GitHub
question
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the issue**

I possess a source code and my goal is to identify any instances of double free vulnerabilities. Technically, the double free vulnerabilities within this source code are associated with three sets of free(): lines 109, 110, and 111, as well as their corresponding pairs at lines 128, 129, and 130. I have examined numerous .ql queries that have been created by the authors of codeql, but none of them have been effective in detecting double free vulnerabilities.
Would anyone be able to assist me with this matter, please?

`
```
#include
#include
#include

typedef struct {
char *type;
int size;
char *data;
} chunk_t;

chunk_t* find_BOOM(FILE *fp) {
char signature[5];
signature[4] = 0; //NULL terminated string
chunk_t* chunkBOOM = NULL;

// check the signature
if (fread(signature, 4, 1, fp)) {
if (strcmp(signature, "ABCD")) {
printf("Error! Invalid file signature\n");
goto quit;
}
} else {
printf("Error! Invalid file\n");
goto quit;
}

// read the content until the end of the file
// or until a BOOM chunk is found
while(!feof(fp)) {
char ctype[5];
ctype[4] = 0; //NULL terminated string
unsigned int csize;
char *cdata = NULL;

// read chunk type
if (fread(ctype, 4, 1, fp)) {
if (fread(&csize, 4, 1, fp)) {

cdata = (char *) malloc(csize);
if (cdata == NULL) {
printf("Error! malloc fails\n");
goto quit;
}

if (fread(cdata, csize, 1, fp)) {
if (!strcmp(ctype, "BOOM") && csize == 8) {
chunkBOOM = (chunk_t *) malloc(sizeof(chunk_t));
if (chunkBOOM == NULL) {
printf("Error! malloc fails\n");
goto quit;
}

chunkBOOM->type = (char *) malloc(5);
if (chunkBOOM->type == NULL) {
printf("Error! malloc fails\n");
goto quit;
}
memcpy(chunkBOOM->type, ctype, 5);

chunkBOOM->size = csize;

chunkBOOM->data = (char *) malloc(csize);
if (chunkBOOM->data == NULL) {
printf("Error! malloc fails\n");
goto quit;
}
memcpy(chunkBOOM->data, cdata, csize);

if (cdata != NULL) free(cdata);
goto quit;
}
} else {
printf("Error while reading chunk data\n");
goto quit;
}
} else {
printf("Error while reading chunk size\n");
goto quit;
}
} else {
if (feof(fp)) {
printf("End of file\n");
break;
}

printf("Error while reading chunk type\n");
goto quit;
}

// free cdata before reading the next chunk
if (cdata != NULL) free(cdata);
}

quit:
return chunkBOOM;
}

void process_BOOM(chunk_t *chunkBOOM) {
unsigned int x, y, z;

if (chunkBOOM == NULL) return;

memcpy(&x, chunkBOOM->data, 4);
memcpy(&y, &(chunkBOOM->data[4]), 4);

z = x + y;
//AIF_RANGE(0,z,284,285);
if ((z > 283) && (z < 286)) {
free(chunkBOOM->type);
free(chunkBOOM->data);
free(chunkBOOM);
}
}

int main(int argc, char** argv) {
FILE *fp;

if ((fp = fopen(argv[1],"rb")) == NULL){
printf("Error! opening file\n");
exit(1);
}

chunk_t *chunkBOOM = find_BOOM(fp);
process_BOOM(chunkBOOM);

if (chunkBOOM != NULL) {
// free chunkBOOM
free(chunkBOOM->type);
free(chunkBOOM->data);
free(chunkBOOM);
}

// close file
fclose(fp);

return 0;
}
````

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.