github / github/codeql

False positive, java/unused-reference-type and JUnit 5 classes

Aberta
#11,989 2 comentários 1 reação 0 responsáveis Ver no GitHub
false-positive
Linguagem predominante
CodeQL
Estrelas
10.1k
Forks
2.1k
Merge médio
2d 15h
PRs com merge (30d)
141

Descrição

JUnit Tests using JUnit 5 are reported as java/unused-reference-type. This is because the JUnit 5 convention is to use package scoped class and method names. This rule should be checking for methods with JUnit annotations (e.g. `@Test`, `@BeforeEach`, `@ParameterizedTest`). The [current check](https://github.com/github/codeql/blob/3059ce307009d40afb690aa712c96e422cf76753/java/ql/src/Violations%20of%20Best%20Practice/Dead%20Code/DeadRefTypes.ql#L44:L45) only looks for subsclassing of TestCase, which hasn't been applicable since JUnit 4.

**Code samples or links to source code**

Example test code that would be reported as unused.
```
class MyTest
{
@Test
void test()
{
// some test code.
}
}
```
Example false positive.
https://github.com/real-logic/aeron/security/code-scanning/1583

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.