github / github/codeql

ImproperCodeSanitization is much slower than other queries

Offen
#11,679 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
question
Vorherrschende Sprache
CodeQL
Sterne
10.1k
Forks
2.1k
Ø Merge
2 T. 15 Std.
Gemergte PRs (30 T.)
141

Beschreibung

**Description of the issue**

This is a follow-up to #10937.

In https://github.com/microsoft/TypeScript/pull/51878, I am removing the exclusions for all of the slow rules mentioned in #10937, and the build now completes without timing out the builder.

But, it's running quite a bit slower than expected; reenabling all of these rules doubles the code scanning time. It appears as though all of this extra time comes from one rule: https://github.com/microsoft/TypeScript/actions/runs/3688169461/jobs/6242652775#step:5:1809

```
[88/88 eval 10m18s] Evaluation done; writing results to codeql/javascript-queries/Security/CWE-094/ImproperCodeSanitization.bqrs.
```

All of the other rules complete in about 3 minutes or less, so this one seems like an outlier to be taking 3x more time than any other rule. It's not a blocker or anything, but I figured I'd report it in case there were some more perf wins to be had.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.