github / github/codeql

LGTM.com - false positive "Statement has no effect" for Python await

Ouverte
#11,235 2 commentaires 2 réactions 0 personnes assignées Voir sur GitHub
false-positive
Langage dominant
CodeQL
Étoiles
10.1k
Forks
2.1k
Merge moyen
2 j 15 h
PR mergées (30 j)
141

Description

**Description of the false positive**

The `await` expression is used to run coroutines, which by design have side-effects. However, CodeQL erroneously treats a bare `await` expression like any other bare expression and thus assumes it has no side-effects and is used in error. This leads to false-positive flags when `await` is used to trigger a side-effect without a return value.

```python3
def foo():
...
# close a critical resource
await aclose
```

**URL to the alert on the project page on ~~LGTM.com~~ GithHub**

https://github.com/maxfischer2781/asyncstdlib/security/code-scanning/9

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.