github / github/codeql

LGTM.com - false positive "Statement has no effect" for Python await

Open
#11,235 2 comments 2 reactions 0 assignees View on GitHub
false-positive
Dominant language
CodeQL
Stars
10.1k
Forks
2.1k
Avg merge
2d 15h
Merged PRs (30d)
141

Description

**Description of the false positive**

The `await` expression is used to run coroutines, which by design have side-effects. However, CodeQL erroneously treats a bare `await` expression like any other bare expression and thus assumes it has no side-effects and is used in error. This leads to false-positive flags when `await` is used to trigger a side-effect without a return value.

```python3
def foo():
...
# close a critical resource
await aclose
```

**URL to the alert on the project page on ~~LGTM.com~~ GithHub**

https://github.com/maxfischer2781/asyncstdlib/security/code-scanning/9

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.