github / github/codeql

CPP: Flow Into Barrier Guards

Aberta
#10,011 15 comentários 0 reações 0 responsáveis Ver no GitHub
question
Linguagem predominante
CodeQL
Estrelas
10.1k
Forks
2.1k
Merge médio
2d 15h
PRs com merge (30d)
141

Descrição

I'm looking for general assistance on how to properly use codeql with barrier guards when the guard condition may not be computed in the guard itself, but instead also data traces into a guard:

Consider these two cases, where `use(x)` is a sink, but if it is guarded by `MyGuard(x)` it is considered safe. The first case is the easy case where BarrierGuard (or SanitizerGuard) can be used fairly easily, and the latter case seems to require yet another dataflow:

```
//Easy case
if(MyGuard(x))
use(x);

//harder case
res = MyGuard(x)
if(res)
use(x);
```

For the latter/harder case, what is the CodeQL paradigm to associate the guard to `x` such that I know use(x) is safe? Seems to me, out of the box, there is no flow from `x` to res. I could add an additional step, in a dataflow/taint analysis, but that would still not let me define barrier guard check conditions to associate that value with the originating variable. Perhaps there is a way to pass around misc. metadata too that will feed into a BarrierGuard check in these cases?

Guia de contribuição

Abrir o guia de contribuição

Avaliação

Esta issue ainda não foi avaliada.

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.