github / github/catalyst

Please define actions workflow permissions

Offen
#329 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
Vorherrschende Sprache
TypeScript
Sterne
1.4k
Forks
59
Ø Merge
22 Std. 12 Min.
Gemergte PRs (30 T.)
5

Beschreibung

## Workflow permissions improvement

There are **3 workflow files** that are currently lacking explicit permissions

### Affected Workflow Files

The following workflow files need permissions to be explicitly defined:

- [`.github/workflows/lighthouse.yml`](https://github.com/github/catalyst/blob/main/.github/workflows/lighthouse.yml)
- [`.github/workflows/nodejs.yml`](https://github.com/github/catalyst/blob/main/.github/workflows/nodejs.yml)
- [`.github/workflows/publish.yml`](https://github.com/github/catalyst/blob/main/.github/workflows/publish.yml)

### Request

Ensure permissions are explicitly defined. Below are Copilot prompts/instructions if you would like Copilot's assistance with addressing this.

## GitHub Copilot Assignment Prompts and Context

**Task**: Add explicit permissions to GitHub Actions workflow files that are currently missing them.

**Scope**: Update the workflow files listed above to include appropriate `permissions:` blocks.

**Analysis Methodology**:
1. **Gather Current State**: Check if the workflow has any existing permissions defined
2. **Inventory Workflow Actions**:
- Actions performed directly by the workflow
- API calls made by the workflow
- External actions included via `uses:` statements
3. **Determine Required Permissions**: Map each action to its minimum required permissions
4. **Synthesize Minimal Permissions**: Create permissions block with only necessary permissions

**Requirements**:
1. Add a `permissions:` block to each workflow file that doesn't have one
2. Start with `contents: read` as the minimum permission
3. Add additional permissions only if the workflow actually needs them based on the actions it performs
4. Place the `permissions:` block at the job level or workflow level as appropriate
5. Ensure the syntax is correct and follows YAML formatting
6. Maintain existing content formatting, including indentation and comments

**Files to modify**: See the list of affected workflow files above.

**Acceptance criteria**:
- [ ] All listed workflow files have explicit permissions defined
- [ ] Permissions follow the principle of least privilege
- [ ] YAML syntax is valid
- [ ] Workflows still function correctly after changes

## Copilot Instructions:

Please create a pull request that adds appropriate `permissions:` blocks to each of the workflow files listed above. Analyze each workflow to determine the minimum permissions required based on the actions it performs, and add only those necessary permissions.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start by reading .github/workflows/lighthouse.yml, .github/workflows/nodejs.yml, and .github/workflows/publish.yml, then inventory each workflow's jobs and uses entries. Determine the minimum permissions required for each workflow, add explicit least-privilege blocks while preserving formatting, and verify the YAML syntax and workflow requirements remain valid.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
github-actions
Bereich
ci-cd, security
Issue-Typ
Feature
Schwierigkeit
3/5
Geschätzter Aufwand
1-2 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
62/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.