@attr boolean/number setter function called with an empty string (v2-beta)
- Dominant language
- TypeScript
- Stars
- 1.4k
- Forks
- 59
- Avg merge
- 22h 12m
- Merged PRs (30d)
- 5
Description
This is maybe related to #117, but not 100% sure on that.
With a component defined like this:
```typescript
import { controller, attr } from '@github/catalyst'
@controller
class TestComponentElement extends HTMLElement {
@attr get booleanProp() {
return false
}
set booleanProp( _v: boolean ) {
console.dir( `booleanProp type: ${ typeof _v }` )
console.dir( `booleanProp value: '${ _v }'` )
}
connectedCallback() {
this.booleanProp = true
}
}
```
and html like this (note the lack of an initial `boolean-prop` value):
```html
```
I get these log messages:
```
booleanProp type: boolean
booleanProp value: 'true'
booleanProp type: string
booleanProp value: ''
```
Changing the html to include an initial value like this:
```html
```
get's rid of that final empty string call:
```
booleanProp type: boolean
booleanProp value: 'true'
```
Maybe this is a limitation? Hopefully this isn't another ghost bug, sorry about the last one 🫣
Contributor guide
Research direction
Start at the @attr decorator entry point and reproduce the behavior with the TypeScript component and HTML snippets in the issue. Trace the setter calls for a missing boolean-prop attribute and compare them with the calls when an initial value is present. Done means the expected setter behavior is established and covered by an appropriate test or documented as a limitation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100