github / github/branch-deploy

Support for multiple deployments in one comment

Abierto
#411 0 comentarios 0 reacciones 0 asignados Ver en GitHub
question
Lenguaje dominante
TypeScript
Estrellas
576
Forks
74
Merge medio
11 h 7 min
PR fusionados (30 d)
1

Descripción

### Details

# Hello

I would like to ask if it is possible to replace `context.payload.comment.body` with a specific comment body that is passed through the workflow call.

The reason I’m asking is that I want to support multiple deployments from a single comment. The repository I’m working on contains many different ArgoCD-managed apps (spread across 10+ clusters).

The way we currently use `.deploy` is like this:
```
.deploy app1-enva
```
where `app1` is the application and `enva` is the cluster where we want to deploy it.

I forked the repo about 2 months ago and made it work by building a matrix from the different `.deploy` commands and then running each sequentially. However, the branch-deploy workflow wanted to use the whole comment, e.g.:
```
.deploy app1-enva .deploy app2-envb
```
So I made some changes in the code and replaced `context.payload.comment.body` with a specific `COMMENT_BODY` passed from the matrix (always the one currently deploying). This worked.

Now, I’ve been asked if there’s a way to merge this change back into the original repo so we don’t need to maintain a separate fork.

So my question is: **Is it possible to merge my changes that replace `context.payload.comment.body` with a specific comment body that gets passed in through the workflow call?** Or it would break too many things for other users?

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza localizando el workflow branch-deploy y cada uso de context.payload.comment.body; después, compara esas rutas con la entrada de workflow COMMENT_BODY propuesta y con el flujo de despliegue basado en matrices. Comprueba cómo se analiza actualmente un único comentario de despliegue y cómo se transmite a través del workflow. Se considera terminado cuando se pueden procesar varios comandos .deploy de forma independiente sin romper el comportamiento existente para un solo comando.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github-actions, typescript
Área
ci-cd, devops
Tipo de issue
Nueva funcionalidad
Dificultad
4/5
Tiempo estimado
3-5 días
Estado de actividad
Estancado
Claridad
Bastante claro
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.