github / github/auto-complete-element

Add client-side options support

Aperta
#52 0 commenti 1 reazione 0 assegnatari Vedi su GitHub
Lingua principale
JavaScript
Stelle
407
Fork
57
Merge medio
1g 7h
PR unite (30g)
5

Descrizione

# Problem
If there are static options passed into the element, the options are deleted on request for filtered options.

# Request
Client-side options should be supported and have filtering available. TBD: Do we allow both client-side (such as default options) *and* server-side options?

# Implementation concerns
## Accessibility
Ensure that any default / client-side options are announced when the input is focused. `screen-reader-announcements.ts` can assist with this.

When the options list isn't visible, an `aria-describedby` should be added to the input pointing to the feedback element. This should only be if the element has client-side options. Remove this `aria-describedby` when the user interacts with any key, and add it back in when the auto-complete-element is blurred. cc @github/accessibility and @jscholes for reference. "aria-live won't cut it" for this scenario

## Developer Notes
There is some initial setup done in `autocomplete.ts` to detect client-side options, but all of this can be removed / reworked, as long as accessibility considerations are met.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start in autocomplete.ts to review the existing client-side option detection, then read screen-reader-announcements.ts for the accessibility behavior. Trace how options are removed during filtered requests and define the supported interaction between client-side and server-side options. Done means client-side options remain available, filtering works, and the described focus, keyboard, blur, and aria-describedby behavior is covered.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
accessibility, frontend, web-dev
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
35/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.