github / github/app

Updater often blocks on app exe still in use

Open
#1,808 0 comments 0 reactions 0 assignees View on GitHub
Bugs
Dominant language
No language data
Stars
2.1k
Forks
153
PR merge metrics
No merged PRs in 30d

Description

### Short summary

_No response_

### Affected version or release

1.0.17 (last I updated from)

### Installation context

_No response_

### What happened?

Lately, whenever an update is downloaded and I restart the app to install it (by clicking on the Restart Now button in the in-app notification), the installer ends up blocking in the middle of the installation because the app exe is still running. I have to wait a non-insignificant amount of time (say, ~30s) before I can retry and continue the installation. This has started happening consistently in the past 10 days or so.

### Steps to reproduce

_No response_

### Expected behavior

I'd expect the installer to wait until the process is closed before starting the update installation.

### Additional context

_No response_

Contributor guide

Open the contributing guide

Research direction

Start with the Restart Now button flow and the installer handoff, then reproduce an update from version 1.0.17 while checking when the app exe process exits. Done means the installer waits for the process to close and continues installation without requiring a manual retry.

Written by the indexing model from the issue text.

Assessment

Domain
desktop, release
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.