github / github/app

.claude/settings.json hooks are now automatically picked up in a non-configurable way

Abierto
#1,717 0 comentarios 1 reacción 0 asignados Ver en GitHub
Bugs
Lenguaje dominante
Sin datos de lenguaje
Estrellas
2.1k
Forks
153
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

### Short summary

claude hooks are now unexpectedly picked up automatically without a way to turn them off

### Affected version or release

v1.0.16

### Installation context

_No response_

### What happened?

In a recent update to the GitHub Copilot app (not sure which, but it began recently), I noticed weird errors in my sessions. It turns out they were caused by hooks in .claude/settings.json that were not previously picked up by the GitHub Copilot app. Claude Code users in the same repo were obviously not expecting their hooks to get picked up by anything other than Claude Code, so the hooks made use of Claude-specific environment variables like CLAUDE_PROJECT_DIR. I added a quick workaround with a fallback if the environment variable that worked on Windows but broke things for our devs on macOS, so I'm working on a second fix to an issue that should not have "appeared" in the first place.

I understand it's great that it tries picking up Claude hooks, but I couldn't find a way to turn it off, and others are likely to find this unexpected surprise feature to be a breaking change, especially if the hooks use Claude-specific environment variables like ours do.

### Steps to reproduce

Use a .claude/settings.json file with hooks configured that assume Claude Code, and that will definitely break outside of it. For instance, assuming CLAUDE_PROJECT_DIR is set.

### Expected behavior

Not picking up Claude Code settings as-is, and especially not without a way to configure it, and even less without a better compatibility layer. It's the automatic picking up of the Claude Code settings without a setting to control it that is the biggest issue.

### Additional context

_No response_

Guía de contribución

Abrir la guía de contribución

Línea de trabajo

Empieza reproduciendo el comportamiento con un archivo .claude/settings.json que contenga hooks que dependan de CLAUDE_PROJECT_DIR, usando GitHub Copilot app v1.0.16. Determina cómo se descubren los ajustes de Claude Code y cómo podría deshabilitarse o hacerse compatible ese comportamiento; se considera terminado cuando los hooks no se ejecutan inesperadamente o los usuarios disponen de un control de configuración documentado.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
github
Área
desktop, developer-experience
Tipo de issue
Error
Dificultad
5/5
Tiempo estimado
Más de una semana
Estado de actividad
Tranquilo
Claridad
Necesita aclaración
Aptitud para principiantes
35/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.