github / github/annotation-toolkit

[Feature request] Add `aria-disabled` guidance to form element annotations

Offen
#32 0 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
backlog improvement set:form-element
Vorherrschende Sprache
Keine Sprachdaten
Sterne
320
Forks
33
Ø Merge
36 Min.
Gemergte PRs (30 T.)
2

Beschreibung

### Description

When annotating form elements that should be non-interactive, the toolkit currently offers a `disabled` toggle. In practice, using the native `disabled` attribute removes the element from the accessibility tree, making it undiscoverable to assistive technology users. The preferred approach in most cases is to use `aria-disabled="true"` instead, which keeps the element discoverable while preventing interaction.

### Requested change

When the disabled state is toggled on for a form element annotation, the annotation should communicate that `aria-disabled` is the recommended approach. This could look like:

- Replacing the simple "disabled: true" label with guidance text, such as: "This field should use `aria-disabled` to maintain accessibility and discoverability"
- Adding a flyout tip (similar to how Primer A11y Presets work) that appears when the toggle is enabled, explaining the rationale

### Why

Using `aria-disabled` instead of `disabled` is a widely recommended practice. By surfacing this guidance directly in the annotation, we can help designers communicate the right implementation to developers without requiring specialized accessibility knowledge.

### References

- [Make disabled buttons accessible](https://advancedbytez.com/make-disabled-buttons-accessible/)

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the form element annotation entry point and inspect how the disabled toggle is represented, then compare it with the existing Primer A11y Presets flyout behavior. Done means that enabling the toggle communicates the aria-disabled recommendation and rationale in the annotation, with the final presentation approach agreed and verified.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
figma
Bereich
accessibility, design
Issue-Typ
Feature
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Veraltet
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
45/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.