github / github/accessibility-scanner

Repeatedly deleting the same file in generated PRs

Open
#126 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
369
Forks
40
Avg merge
1d 9h
Merged PRs (30d)
10

Description

Several of the PR's generated (and now closed) as part of:

https://github.com/mgifford/o-hat-scanner

deleted the same file [‎site/trends.html‎](https://github.com/mgifford/o-hat-scanner/pull/23/changes#diff-1706e21f20dd8b34a1ce279fed8959a5e5609a2c2d6c162be04240af35c67499)

https://github.com/mgifford/o-hat-scanner/pull/23

Not sure how to address this, as I don't know what is wrong with ‎site/trends.html‎

Maybe it just should have been part of one of the pages scanned? Not sure.

But the accessibility scanner should be a little less trigger happy about including files to be deleted in the PRs that they are creating.

Contributor guide

Open the contributing guide

Research direction

Start by reviewing the changes in PR 23, especially the repeated deletion of site/trends.html, then trace the scanner entry point that assembles generated pull requests. Determine why the same file is selected across closed PRs. Done means generated PRs no longer repeatedly include that deletion, with coverage for the behavior if an existing test location is found.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
accessibility, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.