github-vet / github-vet/rangeloop-pointer-findings
hyeoncheon/uart: actions/apps.go; 8 LoC
- Lenguaje dominante
- Sin datos de lenguaje
- Estrellas
- 0
- Forks
- 0
- Métricas de merge de PR
- Métricas de PR pendientes
Descripción
Found a possible issue in [hyeoncheon/uart](https://www.github.com/hyeoncheon/uart) at [actions/apps.go](https://github.com/hyeoncheon/uart/blob/7305ff4e45900d325c8b48c2cf7bbd86e063b243/actions/apps.go#L185-L192)
Below is the message reported by the analyzer for this snippet of code. Beware that the analyzer only reports the first issue it finds, so please do not limit your consideration to the contents of the below message.
>
[Click here to see the code in its original context.](https://github.com/hyeoncheon/uart/blob/7305ff4e45900d325c8b48c2cf7bbd86e063b243/actions/apps.go#L185-L192)
Click here to show the 8 line(s) of Go which triggered the analyzer.
```go
for _, role := range *app.GetRoles() {
rolemaps := &[]models.RoleMap{}
tx.Where("role_id = ?", role.ID).All(rolemaps)
for _, rm := range *rolemaps {
c.Logger().Infof("delete rmap %v: %v", rm.ID, tx.Destroy(&rm))
}
c.Logger().Infof("delete role %v: %v", role.ID, tx.Destroy(&role))
}
```
Click here to show extra information the analyzer produced.
```
No path was found through the callgraph that could lead to a function which writes a pointer argument.
No path was found through the callgraph that could lead to a function which passes a pointer to third-party code.
root signature {Destroy 1} was not found in the callgraph; reference was passed directly to third-party code
```
Leave a reaction on this issue to contribute to the project by classifying this instance as a **Bug** :-1:, **Mitigated** :+1:, or **Desirable Behavior** :rocket:
See the descriptions of the classifications [here](https://github.com/github-vet/rangeclosure-findings#how-can-i-help) for more information.
commit ID: 7305ff4e45900d325c8b48c2cf7bbd86e063b243
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Lee actions/apps.go en las líneas 185-192 del commit 7305ff4e45900d325c8b48c2cf7bbd86e063b243 e inspecciona la ruta de llamadas circundante para determinar el uso de un puntero en el bucle de rango señalado. Determina si el hallazgo del analizador representa un error, un comportamiento mitigado o un comportamiento deseable, y clasifica el issue con la reacción correspondiente.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- go
- Área
- devtools
- Tipo de issue
- Error
- Dificultad
- 4/5
- Tiempo estimado
- 3-5 días
- Estado de actividad
- Estancado
- Claridad
- Necesita aclaración
- Aptitud para principiantes
- 25/100