github-tools / github-tools/github

Creating search from string doesn't work

Abierto
#642 5 comentarios 0 reacciones 0 asignados Ver en GitHub
Lenguaje dominante
JavaScript
Estrellas
3.8k
Forks
809
Métricas de merge de PR
Sin PR fusionados en 30 d

Descripción

Trying to use the function http://github-tools.github.io/github/docs/3.2.3/GitHub.html#search (using 3.4.0 but the docs aren't up for that) like this:
```js
console.log(gh.search('query'))
```
gives this error:
```
/home/heath/SyncedProjects/CredentialReminderBot/node_modules/github-api/dist/components/Requestable.js:162
requestOptions.type = requestOptions.type || 'all';
^

TypeError: Cannot create property 'type' on string 'query'
at Search._getOptionsWithDefaults (/home/heath/SyncedProjects/CredentialReminderBot/node_modules/github-api/dist/components/Requestable.js:162:33)
at new Search (/home/heath/SyncedProjects/CredentialReminderBot/node_modules/github-api/dist/components/Search.js:46:30)
at GitHub.search (/home/heath/SyncedProjects/CredentialReminderBot/node_modules/github-api/dist/components/GitHub.js:159:14)
at Object. (/home/heath/SyncedProjects/CredentialReminderBot/index.js:11:16)
at Module._compile (internal/modules/cjs/loader.js:1201:30)
at Object.Module._extensions..js (internal/modules/cjs/loader.js:1221:10)
at Module.load (internal/modules/cjs/loader.js:1050:32)
at Function.Module._load (internal/modules/cjs/loader.js:938:14)
at Function.executeUserEntryPoint [as runMain] (internal/modules/run_main.js:71:12)
at internal/main/run_main_module.js:17:47
```

Guía de contribución

No hay ninguna guía de contribución indexada para este repositorio

Línea de trabajo

Reproduce the string call and trace the stack through dist/components/GitHub.js, Search.js, and Requestable.js, starting at _getOptionsWithDefaults. Compare the documented search invocation with the current argument handling, then verify the corrected behavior with the relevant existing search checks or a focused regression test.

Escrito por el modelo de indexación a partir del texto del issue.

Evaluación

Stack tecnológico
javascript
Área
api
Tipo de issue
Error
Dificultad
2/5
Tiempo estimado
1-3 horas
Estado de actividad
Estancado
Claridad
Bien especificado
Aptitud para principiantes
45/100

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.