github-tools / github-tools/github
writeFile function fails when response status header is 304 unmodified
未關閉
- 主要語言
- JavaScript
- 星號
- 3.8k
- 分支
- 809
- PR 合併指標
- 30 天內沒有已合併 PR
描述
The response object in the getSha returned promise fails on here `commit.sha = response.data.sha;`
The response.data is null, the status header of the response object is '304 Unmodified'
The writeFile function fails before the PUT requests are created.
https://github.com/github-tools/github/blob/24223f7a51ba935f1c86ffd552dac20e8f3e359d/lib/Repository.js#L732
貢獻指南
這個儲存庫沒有索引到貢獻指南
研究方向
Start in lib/Repository.js at the linked writeFile code, tracing the getSha promise and the response handling around commit.sha = response.data.sha. Confirm the expected behavior for a 304 response and verify that writeFile no longer fails before creating its PUT requests.
由索引模型根據 Issue 內容生成。
評估
- 技術堆疊
- javascript
- 領域
- api
- Issue 類型
- 缺陷
- 難度
- 2/5
- 預估耗時
- 1-3 小時
- 活躍度
- 停滯
- 描述清晰度
- 基本清楚
- 新手友好度
- 48/100