github-tools / github-tools/github

Issues with protected branches: Github is confusing Pull Requests review and push protection

Aberta
#473 1 comentário 0 reações 0 responsáveis Ver no GitHub
Linguagem predominante
JavaScript
Estrelas
3.8k
Forks
809
Métricas de merge de PRs
Nenhum PR com merge em 30d

Descrição

As a Github user, i want to request review for Pull Requests, but, i want to able push on branch.

Setup:
1) Create a branch
2) Protect it, asking review for Pull Requests
3) Do not protect push

Expected Behaviour:
1) Pull Requests require review
2) Push is open on following branch

Actual Scenario:
1) Pull Requests is requiring reviews
2) Got following error while pushing:

```
ramon@Ramons-Mac-mini:~/GIT/SAT-ROBOT (master)$ git push robot master
Counting objects: 2, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (2/2), done.
Writing objects: 100% (2/2), 295 bytes | 0 bytes/s, done.
Total 2 (delta 1), reused 0 (delta 0)
remote: Resolving deltas: 100% (1/1), completed with 1 local object.
remote: error: GH006: Protected branch update failed for refs/heads/master.
remote: error: At least one approved review is required by reviewers with write access.
To https://github.com/SymphonyOSF/SAT-Robot.git
! [remote rejected] master -> master (protected branch hook declined)
error: failed to push some refs to 'https://github.com/SymphonyOSF/SAT-Robot.git'
```

Guia de contribuição

Nenhum guia de contribuição indexado para este repositório

Direção de pesquisa

Start by reproducing the listed protected-branch setup and compare the expected behavior with the GH006 push rejection. The issue mentions no repository file, test, or entry point, so first determine whether the behavior belongs in this GitHub API wrapper or must be clarified as an external GitHub behavior. Done would require a confirmed scope and an actionable change or resolution.

Escrita pelo modelo de indexação a partir do texto da issue.

Avaliação

Stack de tecnologia
github
Domínio
devtools
Tipo de issue
Bug
Dificuldade
5/5
Tempo estimado
Mais de uma semana
Status de atividade
Estagnada
Clareza
Precisa de esclarecimento
Facilidade para iniciantes
25/100

Receba novas issues na sua caixa de entrada

Um resumo curto de issues do GitHub para quem está começando.