github-tools / github-tools/github

Cannot fetch all milestones

Open
#441 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
JavaScript
Stars
3.8k
Forks
809
PR merge metrics
No merged PRs in 30d

Description

I want to fetch all milestones even if the data span multiple pages.
However, currently it fetches only first 30 records.
Then I checked source code and found `listMilestones` method uses `this._request` method ([code](https://github.com/github-tools/github/blob/22b889cd48cd281812b020d85f8ea502af69ddfd/lib/Issue.js#L146))
while other listing methods like `listIssues` use `this._requestAllPages`.
Is this intended?

### Versions

- Node - 6.2.0
- github-api - 3.0.0

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in lib/Issue.js at the listMilestones method referenced by the issue, then compare its request path with listIssues and the _requestAllPages method. Confirm how milestone pagination is handled and verify that fetching milestones returns records from every page rather than only the first 30.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.