github-tools / github-tools/github
[Feature Request] Allow page size option (per_page) in listPullRequestFiles call
- Lenguaje dominante
- JavaScript
- Estrellas
- 3.8k
- Forks
- 809
- Métricas de merge de PR
- Sin PR fusionados en 30 d
Descripción
The listPullRequests call allows an optional second parameter for options that include setting the page size for for a request. GitHub allows `per_page` to also be sent along for the call wrapped by `listPullRequestFiles` but this library doesn't allow options to be passed.
I'm happy to submit a PR but want to know:
1. If you're cool with this
2. How you'd like me to add this functionality without breaking any existing uses of the library that rely on the second parameter being a callback. implement a `listPullRequestFilesWithOptions`?
Guía de contribución
No hay ninguna guía de contribución indexada para este repositorio
Línea de trabajo
Start by locating the listPullRequests and listPullRequestFiles entry points and compare how their parameters and callbacks are handled. Check existing uses or tests for listPullRequestFiles before choosing a backward-compatible options form. Done means callers can pass per_page through to the wrapped GitHub request without breaking callback-based calls.
Escrito por el modelo de indexación a partir del texto del issue.
Evaluación
- Stack tecnológico
- javascript
- Área
- api
- Tipo de issue
- Nueva funcionalidad
- Dificultad
- 3/5
- Tiempo estimado
- 1-2 días
- Estado de actividad
- Estancado
- Claridad
- Bastante claro
- Aptitud para principiantes
- 35/100