github-tools / github-tools/github

Add support for listing Review Comments on a Pull Request

未关闭
#403 2 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
3.8k
派生
809
PR 合并指标
30 天内没有已合并 PR

描述

Currently it's only possible with this library to list comments on an issue, but those are not the same as "Review Comments" on a PR.

See Github's documentation on [Review Comments](https://developer.github.com/v3/pulls/comments/) vs [Comments](https://developer.github.com/v3/issues/comments/):

> Pull Request Review Comments are comments on a portion of the unified diff. These are separate from Commit Comments (which are applied directly to a commit, outside of the Pull Request view), and Issue Comments (which do not reference a portion of the unified diff).

In order to list review comments on a Pull Request, you need to make a call to
`GET /repos/:owner/:repo/pulls/:number/comments`

versus the call for regular issue comments which is
`GET /repos/:owner/:repo/issues/:number/comments`

贡献指南

这个仓库没有索引到贡献指南

调研方向

首先找到列出 issue comments 的库入口点,并将其请求与 GET /repos/:owner/:repo/pulls/:number/comments 进行比较。添加相应的方式来列出 pull-request review comments,然后验证它使用的是 review-comments endpoint,而不是 issue-comments endpoint。

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
api
Issue 类型
功能
难度
2/5
预计耗时
1-3 小时
活跃度
停滞
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。