github-tools / github-tools/github

pagination in listIssueComments

未关闭
#398 0 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
主要语言
JavaScript
星标
3.8k
派生
809
PR 合并指标
30 天内没有已合并 PR

描述

I need to fetch all comments (>50) in an issue, but I don't know how to pass params like
```js
{
per_page: 100,
page: 2
}
```
to [`listIssueComments`](https://github.com/michael/github/blob/master/lib/Issue.js#L65).

I also find that there is a method called `_requestAllPages`, but only applied to [`listIssues`](https://github.com/michael/github/blob/master/lib/Issue.js#L43).

Is is better to add options params or use `_requestAllPages` in `listIssueComments`?

Thanks a lot.

贡献指南

这个仓库没有索引到贡献指南

调研方向

Start by reading lib/Issue.js at listIssues, listIssueComments, and _requestAllPages to understand the existing pagination entry points. Check how listIssueComments is called and documented, then define a consistent way for callers to retrieve more than one page of comments and verify that the behavior is clear from the public API.

由索引模型根据 Issue 内容生成。

评估

技术栈
javascript
领域
api
Issue 类型
功能
难度
4/5
预计耗时
3-5 天
活跃度
停滞
描述清晰度
基本清楚
新手友好度
28/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。