github-tools / github-tools/github
Allow binary blobs
未關閉
enhancement
- 主要語言
- JavaScript
- 星號
- 3.8k
- 分支
- 809
- PR 合併指標
- 30 天內沒有已合併 PR
描述
In order to safely transfer binary blobs/filtes, the API needs to use base64 encoding when appropriate. postBlob() however always uses "utf-8". So there needs to be either an additional argument in write() and postBlob() that specifies the encoding, or postBlob() needs to detect if the file is binary or not, and adjust the encoding automatically.
This little snippet seems to be able to detect binary data:
```
/[\x00-\x08\x0E-\x1F]/.test(data)
```
See http://stackoverflow.com/questions/1677644/detect-non-printable-characters-in-javascript
I'm currently dealing with similar issues in Prose: https://github.com/prose/prose/pull/255
貢獻指南
這個儲存庫沒有索引到貢獻指南
評估
這個 Issue 還沒有評估資料。