github-tools / github-tools/github-release-notes

Incorrect logic in release note creation

Aperta
#282 3 commenti 0 reazioni 0 assegnatari Vedi su GitHub
enhancement
Lingua principale
JavaScript
Stelle
897
Fork
313
Metriche di merge delle PR
Nessuna PR unita negli ultimi 30g

Descrizione

Hi,

I have used gren for both creating changelog file and generating release notes on the GH releases and have the same wrong results in both cases:

```
# Changelog

## v1.0.7 (29/09/2020)
*No changelog for this release.*

---

## v1.0.6 (29/09/2020)
*No changelog for this release.*

---

## v1.0.5 (29/09/2020)
*No changelog for this release.*

---

## v1.0.4 (29/09/2020)
*No changelog for this release.*

---

## v1.0.3 (29/09/2020)
*No changelog for this release.*

---

## v1.0.2 (29/09/2020)
*No changelog for this release.*

---

## v1.0.1 (29/09/2020)
*No changelog for this release.*

---

## v1.0.0 (29/09/2020)
- List of all the 95 PRs we have.
```

So instead of spreading the 95 PRs in their correct releases, they have all been linked to v1.0.0 (which should just have a few).

I guess this is because the tags/releases have not been created at the time of the commit they are referring to. They have all been created today Sep 29th 2020, but each of them correctly points to the right sha1.

If that is the case, I think that being time-based is not a very robust approach, however it should at least be based on the **date of the commit** the tag is referring to and not the tag's date.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by reproducing the changelog and GitHub release output described in the issue with tags created after their target commits. Inspect the release-note generation entry point and how it determines which release contains each pull request. Done means historical pull requests are assigned using the referenced commit date or tag target rather than the tag creation date, with coverage for this scenario.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
javascript
Ambito
release
Tipo di issue
Bug
Difficoltà
3/5
Tempo stimato
1-2 giorni
Stato di attività
Ferma
Chiarezza
Abbastanza chiara
Idoneità per principianti
42/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.