getsentry / getsentry/sentry-ruby

Check for deadlocks in telemetry buffers (logs)

Aperta
#2,898 1 commento 0 reazioni 1 assegnatario Rivendicata da @sl0thentr0py Vedi su GitHub
Improvement Logs Ruby Task
Lingua principale
Ruby
Stelle
987
Fork
541
Merge medio
17h 40m
PR unite (30g)
19

Descrizione

## Context

The Python SDK hit a deadlock in the logs telemetry buffer ([Slack thread]()). The Ruby SDK has a very similar buffer implementation, so we should audit it for the same class of issue.

## Problem (from Python)

* The logs buffer acquires a lock when adding a log and when flushing/clearing the buffer
* During a flush (lock held), GC ran and emitted a log → the logging integration tried to add it to the buffer → attempted to acquire the already-held lock → **deadlock**
* Re-entrant locks didn't help since the GC callback runs on a different thread

## What to check in Ruby

1. **Audit the telemetry buffer lock usage** — ensure no code path can trigger a re-entrant lock acquisition (e.g. via callbacks, GC, instrumentation side-effects during flush)
2. **Minimize critical sections** — the lock should only protect fetch/pop/clear/add operations on the buffer data structure. Envelope construction and other side-effects should happen outside the lock
3. **Consider the .NET approach** — their implementation is mostly lock-free (atomic increments/decrements), only locking briefly during flush to extract a copy of the buffer array before releasing

## Related

* Python fix by Ivana: moved side-effect-producing work outside the locked section
* Java was checked and looks fine (Alexander)
* .NET uses lock-free atomics, had a separate recursion issue with `Debug=true`

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.