getsentry / getsentry/sentry-ruby

Exception inside traces_sampler proc are not raised

Ouverte
#2,348 2 commentaires 0 réactions 1 personne assignée Réclamée par @sl0thentr0py Voir sur GitHub
Good First Issue Improvement Ruby Traces
Langage dominant
Ruby
Étoiles
987
Forks
541
Merge moyen
17 h 40 min
PR mergées (30 j)
19

Description

### Issue Description

Hello,

Please take a look at the example configuration below for a Rails app. I am raising the exception explicitly inside `traces_sampler`. However, when the app boots, I don't see any exception raised. All the requests will fail with 500.

I initially got the variable name wrong inside the initializer and it crashed the app. That is more like a real-world scenario why the config should raise or report an exception.

### Reproduction Steps

- Create a Rails app
- Add the configuration mentioned below at `config/initializers/sentry.rb`
- Boot the Rails app
- Make requests to any routes
- It should fail with 500 without raising an exception

### Expected Behavior

The exception should be raised in the console or reported to Sentry. Right now, there is no way of knowing why my Rails app fails to respond to any requests.

### Actual Behavior

The exception is neither raised nor reported on Sentry if it is raised inside `traces_sampler` proc/lambda.

### Ruby Version

3.3.0

### SDK Version

5.18.1

### Integration and Its Version

rails (8.0.0.alpha e0a9ef1)

### Sentry Config

```
Sentry.init do |config|
config.dsn = ""
config.breadcrumbs_logger = [ :active_support_logger, :http_logger ]

# Set traces_sample_rate to 1.0 to capture 100%
# of transactions for performance monitoring.
# We recommend adjusting this value in production.
config.traces_sampler = lambda do |sampling_context|
rack_env = sampling_context[:env]
if rack_env && rack_env['PATH_INFO'] =~ /up/
return 0.0
else
return 1.0
end
end
end
```

Guide de contribution

Ouvrir le guide de contribution

Évaluation

Cette issue n'a pas encore été évaluée.

Recevez les nouvelles issues par e-mail

Un résumé court des issues GitHub adaptées aux débutants.