getsentry / getsentry/sentry-python

cron interval "too short" warning is spammy

Abierto
#4,116 0 comentarios 0 reacciones 0 asignados Ver en GitHub
Checks Improvement Python Quality Improvement
Lenguaje dominante
Python
Estrellas
2.2k
Forks
669
Merge medio
1 d 1 h
PR fusionados (30 d)
213

Descripción

### How do you use Sentry?

Sentry Saas (sentry.io)

### Version

mainline

### Steps to Reproduce

sentry has a few celerybeat tasks which are configured with very short intervals -- the sdk emits this warning log line every time they run which produces a lot of logspam:

> Intervals shorter than one minute are not supported by Sentry Crons. Monitor 'getsentry-billing-usage-scan-usage-buffer' has an interval of 10 seconds. Use the exclude_beat_tasks option in the celery integration to exclude it.

### Expected Result

it should ideally only warn once per process

perhaps either by (ab)using the python `warnings` system or by wrapping the warning log line in an lru_cache

something like

```python
@functools.cache
def _warn_interval_too_short(monitor_name: str) -> None:
logger.warning(...)
```

### Actual Result

see above

Guía de contribución

Abrir la guía de contribución

Evaluación

Este issue todavía no se ha evaluado.

Recibe los nuevos issues en tu correo

Un resumen breve de issues de GitHub para principiantes.