getsentry / getsentry/sentry-python

Utility function/decorator to mark things as Sentry-patched

未關閉
#3,375 0 則留言 0 個 reaction 已指派 0 人 在 GitHub 檢視
Improvement Python Quality Improvement
主要語言
Python
星號
2.2k
分支
669
平均合併
1 天 1 小時
30 天內合併 PR
213

描述

While reviewing #3358, I had the idea that we might want to make it easier to detect when the SDK has already patched something. This came up because with the `@ensure_integration_enabled` decorator, the function's `__name__` (and similar attributes) are overwritten to make the function look like the original function, so we cannot use these attributes to detect that a function has been patched by Sentry. I originally thought adding this would be necessary for that PR to work, but turns out we don't need it, so I am documenting this idea here, instead.

We could add this to the `@ensure_integration_enabled` decorator and/or make a separate decorator. The decorator would set an attribute called something like `_sentry_patched` on the patched function/class/etc. We could set this attribute simply to `True`, or if we want to make it more informative, maybe we can include some information about what patched the function (maybe the integration class/identifier – we can think about what would be the most helpful).

貢獻指南

開啟貢獻指南

評估

這個 Issue 還沒有評估資料。

把新 issue 寄到你的電子郵件信箱

精選適合新手參與的 GitHub issue 摘要。