getsentry / getsentry/sentry-javascript

Cloudflare capture crashes / data before we export the default fetch handler

Aperta
#24,375 1 commento 0 reazioni 1 assegnatario Rivendicata da @JPeer264 Vedi su GitHub
Cloudflare Workers Feature
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
523

Descrizione

### Problem Statement

Potentially the following Error would never be seen within Sentry:

```js
// file:src/index.ts

import diagnostics_channel from 'diagnostics_channel';

const channel = diagnostics_channel.channel('my-channel');
const app = new Hono();

// never been seen by Sentry
throw new Error();

// never been seen by Sentry
channel.publish({
some: 'data',
});

export default {
fetch: app.fetch,
scheduled: async (batch, env) => {},
}
```

### Solution Brainstorm

Since we introduced cachedClients #23151 we could potentially inject an `Sentry.init` at the top of the workers entrypoint with Vite:

```js
// file:src/index.ts

// following is being injected automatically and uses `Sentry.init`
import ./instrument.js`;

// ... the rest from above ...
```

Theoretically, `instrument.js` only sets up the client so we receive some data, and later the `withSentry` wrapped code would wrap everything as usual and reuses the previously created client.

### Additional Context

This would only work with the v11's default `cacheClient: true` and the entrypoint would not be added when `cacheClient: false`

### Priority

React with 👍 to help prioritize this issue. Please use comments to provide useful context, avoiding `+1` or `me too`, to help us triage it.

Guida per i contributori

Apri la guida per i contributori

Valutazione

Questa issue non è ancora stata valutata.

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.