getsentry / getsentry/sentry-javascript

Link cache-hits to the trace that filled the cache entry

Aperta
#24,294 1 commento 0 reazioni 0 assegnatari Vedi su GitHub
javascript
Lingua principale
TypeScript
Stelle
8.7k
Fork
1.8k
Merge medio
1g 17h
PR unite (30g)
523

Descrizione

*Example:* a product page uses

```
async function getProducts() {
'use cache';
cacheLife('hours');
return db.query('SELECT * FROM products');
}
```

Visitor A at 09:00 misses. The DB query runs, 800 ms, trace A. Visitor B at 14:00 gets a 2 ms hit and complains about yesterday's price. B's trace shows a fast green `cache.get` and nothing else. Trace A, where the content came from, cannot be found from B.

*Solves:* you can navigate from any cache hit to the render that produced the content. One bad render can serve thousands of visitors, and today the render is the one trace you cannot reach.

*Fix idea:* at handler `set`, store the active trace context keyed by cache-key digest (mechanism per the transport decision, 3.2). At a `get` hit, always attach a real span link: `span.addLink()` with `sentry.link.type: 'cache_origin'` pointing at the fill span. The link is unconditional and the durable data model; it renders in the span drawer today and needs no SDK change once Sentry stores links first-class. Separately, duplicate it into the flat bridge attribute, but only if the backend meeting lands on "EAP links take too long". The prototype verified the link round-trips. Acceptance: an E2E miss/hit pair shows the span link on the hit transaction, independent of the bridge attribute.

Guida per i contributori

Apri la guida per i contributori

Direzione di ricerca

Start by locating the cache handler's set and get paths and reviewing the transport decision in section 3.2, then inspect the existing prototype's round-trip behavior. Add an end-to-end miss/hit case and verify that the hit transaction shows a cache_origin span link independently of the flat bridge attribute.

Scritto dal modello di indicizzazione a partire dal testo della issue.

Valutazione

Stack tecnologico
typescript
Ambito
observability
Tipo di issue
Funzionalità
Difficoltà
4/5
Tempo stimato
3-5 giorni
Stato di attività
Attiva
Chiarezza
Abbastanza chiara
Idoneità per principianti
48/100

Ricevi le nuove issue nella tua casella

Un breve riepilogo di issue GitHub adatte ai principianti.