getsentry / getsentry/sentry-javascript

node-integration-tests: port trace semantics suites to span streaming

Offen
#24,140 3 Kommentare 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
javascript Task
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
523

Beschreibung

Follow the porting recipe in the parent issue.

Sampling, DSC, envelope headers and span linking. These suites assert on envelope headers and trace propagation rather than on instrumentation output, so they are the ones most likely to expose a real product bug rather than a test rewrite.

## Suites

* Envelope headers and DSC: `tracing/envelope-header/*` (7 dirs), `tracing/dsc-txn-name-update`, `tracing/double-baggage/*` (3 dirs), `tracing/meta-tags`, `tracing/meta-tags-twp`, `tracing/meta-tags-twp-errors`
* Sampling: `tracing/sampling-static`, `tracing/sample-rate-propagation/*` (4 dirs), `tracing/sample-rand-propagation`, `tracing/no-parent-span-client-report`
* Trace lifetime: `tracing/continueTrace`, `tracing/startNewTrace`, `tracing/traceid-recycling`, `tracing/traceid-recycling-with-spans`
* Span shaping: `tracing/linking`, `tracing/maxSpans`, `tracing/tracer-start-active-span-error`
* Public API span surface: `public-api/startSpan/*` (7 dirs), `public-api/beforeSendSpan-static`, `public-api/bindScopeToEmitter`, `public-api/setMeasurement`, `public-api/scopes/*`

## Twins to fold back

`tracing/sampling-streamed`, `tracing/ignoreSpans-streamed/*`, `public-api/beforeSendSpan-streamed`, `context-streamed/*`, and the 6 `public-api/startSpan/*-streamed` dirs.

## Keep static trace lifecycle coverage

This is the group that owns the guard. Keep `tracing/sampling-static` and `public-api/beforeSendSpan-static` on the static pin. Everything else moves.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the porting recipe in the parent issue, then inspect the listed tracing/* and public-api/* suites and their -streamed twins. Port the specified suites to span streaming, fold back the named twins, and keep tracing/sampling-static and public-api/beforeSendSpan-static on the static pin. Done means the listed integration suites cover sampling, propagation, span linking, and public API behavior under span streaming.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
node.js, typescript
Bereich
testing
Issue-Typ
Refactoring
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
52/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.