getsentry / getsentry/sentry-javascript

node-integration-tests: port GraphQL suites to span streaming

Open
#24,139 1 comment 0 reactions 0 assignees View on GitHub
javascript Task
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
523

Description

Follow the porting recipe in the parent issue.

Small group, but the span names change the most: GraphQL phase spans now use the low cardinality fallback name and carry `graphql.processing.type`, and the segment name update from `useOperationNameForRootSpan` lands on the segment span instead of the transaction name.

## Suites

* `tracing/apollo-graphql`, `tracing/apollo-graphql/resolvers`, `tracing/apollo-graphql/useOperationNameForRootSpan`
* `tracing/graphql-tracing-channel`, `tracing/graphql-tracing-channel/resolvers`, `tracing/graphql-tracing-channel/useOperationNameForRootSpan`
* `aws-serverless/graphql/useOperationNameForRootSpan`

No `-streamed` twins exist for this group.

Contributor guide

Open the contributing guide

Research direction

Start with the parent issue's porting recipe, then inspect the listed suites under tracing/apollo-graphql, tracing/graphql-tracing-channel, and aws-serverless/graphql. Update the suites for the specified GraphQL span names, processing type, and segment-name behavior; done means all listed suites are ported and their tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, node.js, typescript
Domain
testing-qa
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.