getsentry / getsentry/sentry-javascript

node-integration-tests: port HTTP and outgoing request suites to span streaming

Offen
#24,135 1 Kommentar 0 Reaktionen 0 zugewiesene Personen Auf GitHub ansehen
javascript Task
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
523

Beschreibung

Follow the porting recipe in the parent issue.

Highest churn group, because `http.server` and `http.client` span names became low cardinality. Do this one first, since the other groups inherit its patterns.

## Suites

* `tracing/requests/*` (15 dirs)
* `tracing/http-client-spans/*` (8 dirs)
* `tracing/httpIntegration`
* `tracing/tracePropagationTargets` and `tracing/tracePropagationTargets/baggage-org-id`
* `proxy`
* `ipv6`

## Twins to fold back

* `tracing/httpIntegration-streamed` into `tracing/httpIntegration`
* `tracing/http-client-spans/fetch-basic-streamed` into `tracing/http-client-spans/fetch-basic`

`tracing/http-client-span-streamed`, `tracing/httpServerSpans-streamed-unrouted` and `tracing/requestData-streamed` have no static original. Rename them to drop the `-streamed` suffix once nothing collides.

Beitragsleitfaden

Beitragsleitfaden öffnen

Rechercherichtung

Start with the parent issue's porting recipe, then inspect the listed tracing, proxy, and ipv6 suites and their streamed twins. Follow the recipe across the named directories, fold back the two specified twins, and rename the three streamed-only suites when there are no collisions. Done means the listed HTTP and outgoing-request suites are ported consistently without duplicate suite names.

Vom Indexierungsmodell aus dem Issue-Text verfasst.

Bewertung

Tech-Stack
node.js, typescript
Bereich
api, backend, testing
Issue-Typ
Refactoring
Schwierigkeit
4/5
Geschätzter Aufwand
3-5 Tage
Aktivitätsstatus
Aktiv
Klarheit
Größtenteils klar
Anfängerfreundlichkeit
48/100

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.