getsentry / getsentry/sentry-javascript

node-integration-tests: port HTTP and outgoing request suites to span streaming

Open
#24,135 1 comment 0 reactions 0 assignees View on GitHub
javascript Task
Dominant language
TypeScript
Stars
8.7k
Forks
1.8k
Avg merge
1d 17h
Merged PRs (30d)
515

Description

Follow the porting recipe in the parent issue.

Highest churn group, because `http.server` and `http.client` span names became low cardinality. Do this one first, since the other groups inherit its patterns.

## Suites

* `tracing/requests/*` (15 dirs)
* `tracing/http-client-spans/*` (8 dirs)
* `tracing/httpIntegration`
* `tracing/tracePropagationTargets` and `tracing/tracePropagationTargets/baggage-org-id`
* `proxy`
* `ipv6`

## Twins to fold back

* `tracing/httpIntegration-streamed` into `tracing/httpIntegration`
* `tracing/http-client-spans/fetch-basic-streamed` into `tracing/http-client-spans/fetch-basic`

`tracing/http-client-span-streamed`, `tracing/httpServerSpans-streamed-unrouted` and `tracing/requestData-streamed` have no static original. Rename them to drop the `-streamed` suffix once nothing collides.

Contributor guide

Open the contributing guide

Research direction

Start with the parent issue's porting recipe, then inspect the listed tracing, proxy, and ipv6 suites and their streamed twins. Follow the recipe across the named directories, fold back the two specified twins, and rename the three streamed-only suites when there are no collisions. Done means the listed HTTP and outgoing-request suites are ported consistently without duplicate suite names.

Written by the indexing model from the issue text.

Assessment

Tech stack
node.js, typescript
Domain
api, backend, testing
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.