getsentry / getsentry/sentry-javascript

Port cloudflare-integration-tests to span streaming

Offen
#24,132 1 Kommentar 0 Reaktionen 1 zugewiesene Person Beansprucht von @JPeer264 Auf GitHub ansehen
javascript Task
Vorherrschende Sprache
TypeScript
Sterne
8.7k
Forks
1.8k
Ø Merge
1 T. 17 Std.
Gemergte PRs (30 T.)
523

Beschreibung

Port `dev-packages/cloudflare-integration-tests` to span streaming. Span streaming is the default, so every suite that still pins `traceLifecycle: 'static'` covers behaviour we no longer ship.

Part of [SDK-1425](https://linear.app/getsentry/issue/SDK-1425/port-integration-tests-to-span-streaming), one tracking issue per integration test package.

## Scope

* 102 `traceLifecycle: 'static'` pins across 82 files
* 2 suites already have a `-streamed` twin: `tracing/ignoreSpans-streamed` and `public-api/startSpan-streamed`
* `tracing/d1` uses an env-gated `STREAMED` switch
* This package has no shared span helpers. Every streamed test hand-rolls its own `getSpanContainer`, so the helper work comes first.

## How to port a suite

1. Remove the `traceLifecycle: 'static'` pin from every `Sentry.init` in the suite.
2. If a `-streamed` twin exists, fold it back: delete the static original and rename the twin to the base name.
3. Rewrite the assertions from transaction envelopes to span v2 against the shared helper added in the first sub-issue:
* `event.transaction` becomes `span.name`
* `contexts.trace.op` becomes the `sentry.op` attribute plus `span.is_segment`
* `contexts.trace.data['x']` becomes `span.attributes['x']`, which has the shape `{ value, type }`
* `transaction_info.source` becomes the `sentry.segment.name.source` attribute

Watch for span names that become low cardinality under streaming: `http.server`, `http.client`, `db`, `cache` and `gen_ai`.

Reference suite: `suites/public-api/startSpan-streamed`.

## Keep static trace lifecycle coverage

Keep one suite on the static pin as a guard rather than duplicating each one. Name it in the PR.

Beitragsleitfaden

Beitragsleitfaden öffnen

Bewertung

Dieses Issue wurde noch nicht bewertet.

Neue Issues direkt in Ihr Postfach

Eine kurze Übersicht über anfängerfreundliche GitHub-Issues.