getsentry / getsentry/sentry-javascript

Port node-integration-tests to span streaming

未关闭
#24,130 1 条评论 0 个 reaction 已指派 0 人 在 GitHub 查看
javascript Task
主要语言
TypeScript
星标
8.7k
派生
1.8k
平均合并
1 天 17 小时
30 天内合并 PR
523

描述

Port `dev-packages/node-integration-tests` to span streaming. Span streaming is the default, so every suite that still pins `traceLifecycle: 'static'` covers behaviour we no longer ship.

Part of [SDK-1425](https://linear.app/getsentry/issue/SDK-1425/port-integration-tests-to-span-streaming), one tracking issue per integration test package.

## Scope

* 299 `traceLifecycle: 'static'` pins across 188 suite directories
* 111 suite directories assert on transaction envelopes and need a real rewrite
* 19 suites already have a `-streamed` twin next to the static original
* 20 suites use the env-gated `traceLifecycle: process.env.STREAMED === 'true' ? 'stream' : 'static'` pattern

## How to port a suite

1. Remove the `traceLifecycle: 'static'` pin from every `Sentry.init` in the suite.
2. If a `-streamed` twin exists, fold it back: delete the static original and rename the twin to the base name. Do not keep both, or the coverage doubles and the two copies drift.
3. If the suite uses the env-gated `STREAMED` switch, drop the switch and keep `'stream'`.
4. Rewrite the assertions from transaction envelopes to span v2:
* `.expect({ transaction })` becomes `.expect({ span })`, which gives a `SerializedStreamedSpanContainer`
* `event.transaction` becomes `span.name`
* `contexts.trace.op` becomes the `sentry.op` attribute plus `span.is_segment`
* `contexts.trace.data['x']` becomes `span.attributes['x']`, which has the shape `{ value, type }`
* `transaction_info.source` becomes the `sentry.segment.name.source` attribute
5. Streamed child spans arrive across several envelopes, so collect across envelopes wherever a test asserts on children of a segment span.

Watch for span names that become low cardinality under streaming: `http.server`, `http.client`, `db`, `cache`, `gen_ai` and `graphql`. Those assertions change, not just the helper.

Reference suite: `suites/tracing/httpIntegration-streamed`.

## Keep static trace lifecycle coverage

Do not add a `-static` copy per suite. `tracing/sampling-static` and `public-api/beforeSendSpan-static` already guard the static lifecycle for this package.

贡献指南

打开贡献指南

调研方向

Start in dev-packages/node-integration-tests and compare suites against tracing/httpIntegration-streamed. Locate static and STREAMED traceLifecycle pins, then inspect transaction-envelope assertions and child-span collection in the affected suites. Done means the package uses span streaming throughout, streamed twins are folded back, assertions cover span v2, and tracing/sampling-static plus public-api/beforeSendSpan-static remain the static coverage.

由索引模型根据 Issue 内容生成。

评估

技术栈
node.js, typescript
领域
testing-qa
Issue 类型
重构
难度
5/5
预计耗时
一周以上
活跃度
活跃
描述清晰度
描述清楚
新手友好度
35/100

把新 issue 发到你的邮箱

精选适合新手参与的 GitHub issue 摘要。